[PATCH] D115859: [LoongArch 2/6] Add ELF machine flag and relocs for upcoming LoongArch target

Thu Feb 10 10:56:26 PST 2022

rengolin added a comment.

In D115859#3311808 <https://reviews.llvm.org/D115859#3311808>, @rastogishubham wrote:

> Hi it seems like this patch caused an error in the lldb build machines:
>
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/BinaryFormat/ELF.h:877:1: error: expected identifier
> #include "ELFRelocs/LoongArch.def"
> ^

I'm not sure how that's possible, given that that the code here isn't doing anything different than any other backend.

The only thing I could think about was the extra newline on LoogArch's enum defs that wasn't present in any other arch.

So I committed 695b629edd03 <https://reviews.llvm.org/rG695b629edd032622564bfcb18fafb86dee88ea9d> removing that newline. It's a wild guess, it's not relevant and it shouldn't hurt, but if that's what it was (because macros are stupid), then let me know.

If not, then we need to understand how you're building it because the other bots are fine and that is a build failure.

Ex. https://lab.llvm.org/buildbot/#/builders/188/builds/9576

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115859/new/

https://reviews.llvm.org/D115859