[PATCH] D119439: [libc++] Remove __functional_base

Thu Feb 10 10:49:35 PST 2022

philnik added inline comments.

================
Comment at: libcxx/test/std/ranges/range.factories/range.iota.view/iterator/minus.pass.cpp:20
+#include <cstdint>
+#include <ranges>

----------------
Quuxplusone wrote:
> Please leave `<ranges>` first; historically this is our style for tests that test a particular header (although I admit I don't see much point to it).
I didn't know that rule and nobody has said anything in my other PRs until now, so I'd like to know @ldionne's opinion on this. I don't see much point to it either.

================
Comment at: libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.ctor/deduct.pass.cpp:22

+#include <functional>
 #include <memory>
----------------
Quuxplusone wrote:
> This doesn't look needed. Why would we need this here?
This is needed in `deduction_guides_sfinare_checks.h` for `std::equal_to` (I think). Including it directly in the header didn't work. I'm not sure if this is a compiler bug, or if it's intended.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119439/new/

https://reviews.llvm.org/D119439