[PATCH] D118694: [Bitcode] Add partial support for opaque pointer auto-upgrade

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 10 10:25:58 PST 2022


aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

sorry for the slow review, I think this is fine
I agree constructing invalid bitcode is probably not worth the time



================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:487
+  std::vector<Type *> TypeList;
+  std::vector<Type *> ElementTypeList;
   DenseMap<Function *, FunctionType *> FunctionTypes;
----------------
perhaps a comment here would be good


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118694/new/

https://reviews.llvm.org/D118694



More information about the llvm-commits mailing list