[PATCH] D114181: Add semantics unit test for SYNC ALL statement

Katherine Rasmussen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 10 10:14:54 PST 2022


ktras accepted this revision.
ktras added a comment.
This revision is now accepted and ready to land.

LGTM. The only note is that this test should pass if you take away the XFAIL directive, but doesn't because flang doesn't currently enforce the following constraints stated in the standard: C1171 - that no specifier shall appear more than once in a given `sync-stat-list`, and C1172 - that a `stat-variable` or `errmsg-variable` in a `sync-stat` shall not be a `coindexed object`. It seems appropriate to open up an issue on the github repository pointing this out after this commit is pushed, and referencing this test in the issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114181/new/

https://reviews.llvm.org/D114181



More information about the llvm-commits mailing list