[PATCH] D119332: [flang] Add Win32 to the list of supported triples

Thu Feb 10 09:34:51 PST 2022

clementval added a comment.

In D119332#3310757 <https://reviews.llvm.org/D119332#3310757>, @awarzynski wrote:

> In D119332#3310553 <https://reviews.llvm.org/D119332#3310553>, @clementval wrote:
>
>> On our side we do not run any test suites on windows.
>
> It sounds that you are very unlikely to hit this case then (i.e. this is always going to be true in your test/dev env: `triple != -{}-{}-windows-win32`). But we do have Windows pre-merge and post-merge testing, so it's not like this is not tested at all.
>
>> I'm just hoping this does not cause problem while we upstream the rest of fir-dev.
>
> Upstreaming remains our top-priority. If this change becomes a blocker, we can revert it.

Ok for me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119332/new/

https://reviews.llvm.org/D119332