[PATCH] D98152: [InstCombine] Canonicalize SPF to min/max intrinsics

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 10 05:47:42 PST 2022


RKSimon added a comment.

A local rebase indicates that after rGaca355a3bb99 <https://reviews.llvm.org/rGaca355a3bb9917b7e47cf7dc04ad7a96dfa0d43d> the most obvious regressions have been squashed



================
Comment at: llvm/test/Transforms/InstCombine/select-pr39595.ll:8
+; CHECK-NEXT:    [[TMP2:%.*]] = xor i32 [[TMP1]], -1
+; CHECK-NEXT:    ret i32 [[TMP2]]
+;
----------------
We lose pgo data here - I'm not sure whether this is an issue or not - PR39595 had branch weight metadata but it doesn't appear to have been critical to the bug.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98152/new/

https://reviews.llvm.org/D98152



More information about the llvm-commits mailing list