[PATCH] D116602: [SVE][CodeGen] Bail out for scalable vectors in AArch64TargetLowering::ReconstructShuffle

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 10 05:39:30 PST 2022


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM, but I'd prefer if you could move out some of the tests.



================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-reshuffle.ll:26
+
+define <2 x i1> @reshuffle_v2i1_nxv4i1(<vscale x 4 x i1> %a) #0 {
+; CHECK-LABEL: reshuffle_v2i1_nxv4i1:
----------------
Other than the test above, I'd suggest removing this test and the others below from this patch and submitting them as a separate NFC patch (as precursor to D119427).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116602/new/

https://reviews.llvm.org/D116602



More information about the llvm-commits mailing list