[PATCH] D119425: [AMDGPU] Make enable-flat-scratch an attribute

Thu Feb 10 04:09:31 PST 2022

sebastian-ne added a comment.

In D119425#3310638 <https://reviews.llvm.org/D119425#3310638>, @foad wrote:

> Just curious: why is it not enabled by default on subtargets that support it? Then you would only need the attribute if you wanted to turn it off for some reason.

If we do so, I think it only makes sense for gfx10.3+ (there are a couple hardware bugs before that). It would need benchmarking on the compute side.
For graphics there are almost no differences when using flat scratch, but there is one improvement in a case where we spill a lot.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119425/new/

https://reviews.llvm.org/D119425