[PATCH] D119332: [flang] Add Win32 to the list of supported triples

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

>> Have you tried this patch on fir-dev?
>
> Yes and everything worked fine for me. Though I only tested on Linux (not sure that matters though, most/all tests seem to use `--target=x86_64-unknown-linux-gnu`).
>
> I didn't see anything that would be OS (or ABI) specific in `KindMapping`, which is what `fir::CodeGenSpecifics::get` effectively returns. To me this looks like a fairly safe change to make.

On our side we do not run any test suites on windows. I'm just hoping this does not cause problem while we upstream the rest of fir-dev.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119332/new/

https://reviews.llvm.org/D119332