[PATCH] D119332: [flang] Add Win32 to the list of supported triples

Thu Feb 10 02:49:28 PST 2022

awarzynski added a comment.

> Out of curiosity, how much has this been tested?

Diana is experimenting on Windows. That's probably it at the moment.

> I wouldn't be surprised if there are some gotcha differences between the Windows and Linux ABIs...

Possibly. But we won't be able to test at all unless this code-path is enabled, right?

> Have you tried this patch on fir-dev?

Yes and everything worked fine for me. Though I only tested on Linux (not sure that matters though, most/all tests seem to use `--target=x86_64-unknown-linux-gnu`).

I didn't see anything that would be OS (or ABI) specific in `KindMapping`, which is what `fir::CodeGenSpecifics::get` effectively returns. To me this looks like a fairly safe change to make.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119332/new/

https://reviews.llvm.org/D119332