[PATCH] D119252: [AArch64][SVE] Fix selection failure during lowering of shuffle_vector

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-shuffles.ll:18
+; Ensure we don't crash when trying to lower a shuffle via and extract
+define void @crash_when_lowering_extract_shuffle(<32 x i32>* %dst, i1 %cond) #0 {
+; CHECK-LABEL: crash_when_lowering_extract_shuffle:
----------------
sdesmalen wrote:
> nit: For tests that rely on `vscale_range` I personally find the tests more readable if instead of referencing some attribute, it just has `vscale_range(2, 2)` here directly, and the RUN line has the `+sve` attribute. For this test it doesn't really matter too much I guess, but if the test file is long, the `#<some number>` make it really obscure what vscale_range it refers to.
I tend to agree with the first point when it comes to a single file when several different `vscale_range` values are being tested, although in this case all the tests are using the same value.  The second point I personally disagree with because I prefer the convenience of generally being able to do `llc < test.ll` without having to always dig into the test file in order to run it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119252/new/

https://reviews.llvm.org/D119252