[PATCH] D119354: [ARM] Patterns for vector conversion between half and float

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 10 01:16:25 PST 2022


dmgreen added a comment.

The change here LGTM too. Remember to upload with context :)



================
Comment at: llvm/test/CodeGen/ARM/fp16-vector-cvt.ll:4
+
+target triple = "thumbv8a-none-unknown-eabi"
+
----------------
I think you can remove this, and the "hidden"s below too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119354/new/

https://reviews.llvm.org/D119354



More information about the llvm-commits mailing list