[PATCH] D119391: [X86] Only force FP usage in the presence of pushf/popf on Win64

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

This approach works, too (in addition to D92695 <https://reviews.llvm.org/D92695>) and is simpler (though, should `X86FrameLowering::has128ByteRedZone` now return `false` for frame using the intrinsics that aren't wincfi? If so, then modification to that method too will degenerate into D92695 <https://reviews.llvm.org/D92695>).

Consider whether D119382 <https://reviews.llvm.org/D119382> still has value; if it does, perhaps it should land first and/or this patch made a child of it; otherwise happy to abandon it.

Also, in D92695 <https://reviews.llvm.org/D92695>, I modify llvm/test/CodeGen/X86/x86-64-flags-intrinsics.ll. I'm not sure what's preferred for that test. PTAL

It would be helpful to have in the commit message for this patch that it

Fixes: https://github.com/llvm/llvm-project/issues/46875


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119391/new/

https://reviews.llvm.org/D119391