[PATCH] D119394: [lld-macho][nfc] Centralize usages of ld64.lld in tests

Vincent Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 17:09:50 PST 2022


thevinster created this revision.
Herald added a project: lld-macho.
Herald added a reviewer: lld-macho.
thevinster edited the summary of this revision.
thevinster published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We have a mix of substituted lld (`%lld`) and hard-coded lld (`ld64.lld`) commands.
In the event of a rename, this would require going into every place where lld 
is hard-coded and changing that. If we centralize the raw usage, this'll only 
require us to modify it only one place. Arguably, I don't think the name will change
anytime soon, but it would be nice to be consistent with how we write other tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119394

Files:
  lld/test/MachO/adhoc-codesign.s
  lld/test/MachO/invalid/stub-link.s
  lld/test/MachO/lit.local.cfg
  lld/test/MachO/reproduce.s
  lld/test/MachO/reroot-path.s
  lld/test/MachO/search-paths-darwin.test
  lld/test/MachO/skip-platform-checks.s
  lld/test/MachO/syslibroot.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119394.407355.patch
Type: text/x-patch
Size: 13656 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220210/360b1d2a/attachment.bin>


More information about the llvm-commits mailing list