[PATCH] D92695: [X86ISelLowering] don't emit frame pointers for eflags intrinsics.

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:27271
+      else
+        MF.getFunction().addFnAttr(Attribute::NoRedZone);
       // Don't do anything here, we will expand these intrinsics out later
----------------
void wrote:
> craig.topper wrote:
> > Do we have precedent for modifying an IR function from inside of a MachineFunctionPass.
> I believe it's generally frowned upon.
If the tests look good and everyone's happy with the tests, then I can find another way to plumb this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92695/new/

https://reviews.llvm.org/D92695