[lld] 666aa43 - Fix comment after upstream: 9e08e9298059651e4f42eb608c3de9d4ad8004b2 - [ELF] Allow STV_PROTECTED shared definition to set exportDynamic?

Ben Dunbobbin via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 15:53:21 PST 2022


Author: Ben Dunbobbin
Date: 2022-02-09T23:51:31Z
New Revision: 666aa43cbf829421b470c1ef6cf585d1dd3c94fd

URL: https://github.com/llvm/llvm-project/commit/666aa43cbf829421b470c1ef6cf585d1dd3c94fd
DIFF: https://github.com/llvm/llvm-project/commit/666aa43cbf829421b470c1ef6cf585d1dd3c94fd.diff

LOG: Fix comment after upstream: 9e08e9298059651e4f42eb608c3de9d4ad8004b2 - [ELF] Allow STV_PROTECTED shared definition to set exportDynamic?

Added: 
    

Modified: 
    lld/ELF/Symbols.h

Removed: 
    


################################################################################
diff  --git a/lld/ELF/Symbols.h b/lld/ELF/Symbols.h
index 2ea7e96522a22..c499964ec35dd 100644
--- a/lld/ELF/Symbols.h
+++ b/lld/ELF/Symbols.h
@@ -113,7 +113,8 @@ class Symbol {
   // whether it is required to be exported into .dynsym. This is set when any of
   // the following conditions hold:
   //
-  // - If there is an interposable symbol from a DSO.
+  // - If there is an interposable symbol from a DSO. Note: We also do this for
+  //   STV_PROTECTED symbols which can't be interposed (to match BFD behavior).
   // - If -shared or --export-dynamic is specified, any symbol in an object
   //   file/bitcode sets this property, unless suppressed by LTO
   //   canBeOmittedFromSymbolTable().


        


More information about the llvm-commits mailing list