[PATCH] D92695: [X86ISelLowering] don't emit frame pointers for eflags intrinsics.

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 15:52:31 PST 2022


void added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:27271
+      else
+        MF.getFunction().addFnAttr(Attribute::NoRedZone);
       // Don't do anything here, we will expand these intrinsics out later
----------------
craig.topper wrote:
> Do we have precedent for modifying an IR function from inside of a MachineFunctionPass.
I believe it's generally frowned upon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92695/new/

https://reviews.llvm.org/D92695



More information about the llvm-commits mailing list