[PATCH] D119380: [lld][CMake] Add a warning about the Standalone build being deprecated

Wed Feb 9 15:42:15 PST 2022

MaskRay added a comment.

In D119380#3309341 <https://reviews.llvm.org/D119380#3309341>, @andrewrk wrote:

> My goal is to use the same method for compiling llvm, clang, and lld as package maintainers, so that we don't get any "surprises" when someone packages our application using system llvm, lld, clang packages. I don't really care which way is the correct way to compile the software but the existence of multiple ways to do it creates problems for me.

Your bug report demonstrates that you are(or were?) a standalone build user. For the unknown downstream standalone users, I want to be conservative and not disrupt their workflow too much.
Therefore I consider a warning for release/14.x <https://github.com/llvm/llvm-project/tree/release/14.x>.

For the main branch I'll use a FATAL_ERROR. I'm preparing a similar patch for Clang as I think the standalone build is also broken there.

-DLLVM_ENABLE_RUNTIMES is for 'libcxx;libcxxabi;libunwind;compiler-rt'. Every else top-level project uses LLVM_ENABLE_PROJECTS.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119380/new/

https://reviews.llvm.org/D119380