[PATCH] D112735: export unique symbol list with llvm-nm new option "--export-symbols"
Digger Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 9 13:53:34 PST 2022
DiggerLin updated this revision to Diff 407285.
DiggerLin added a comment.
1. address comment.
2. removing the symbols which should not print before removing duplication symbols. and add a new test for it.
- Name: __tf2value Section: .data Type: 0x0 StorageClass: C_HIDEXT AuxEntries:
- Type: AUX_CSECT SymbolAlignmentAndType: 0x21 StorageMappingClass: XMC_TC
Sometime we have two symbols, which both has the same name and no visibility, one's storageClass is C_HIDEXT (the should not be export), another is C_EXT(the one should be exported).
When compare these two symbols for "--export-symbols", these two symbol are same, if we remove duplication symbol before removing the symbols which should not print. the Symbol with C_EXT maybe removed. it will cause none of the two symbol be printed out.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112735/new/
https://reviews.llvm.org/D112735
Files:
llvm/docs/CommandGuide/llvm-nm.rst
llvm/include/llvm/BinaryFormat/XCOFF.h
llvm/include/llvm/Object/XCOFFObjectFile.h
llvm/lib/Object/XCOFFObjectFile.cpp
llvm/test/tools/llvm-nm/Inputs/bitcode-sym32.ll
llvm/test/tools/llvm-nm/Inputs/bitcode-sym64.ll
llvm/test/tools/llvm-nm/XCOFF/export-symbols.test
llvm/test/tools/llvm-nm/bitcode-export-sym.test
llvm/tools/llvm-nm/Opts.td
llvm/tools/llvm-nm/llvm-nm.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112735.407285.patch
Type: text/x-patch
Size: 27130 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220209/02c756c6/attachment.bin>
More information about the llvm-commits
mailing list