[PATCH] D118877: [DagCombine] Increase depth by number of operands to avoid a pathological compile time.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 13:28:51 PST 2022


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

I understand that this is not a complete solution to these pathological compile time cases, but this does address some of them, and I think it's important to put correctness before performance. These timeouts are affecting our users, so we have some urgency and can't wait to develop a perfect solution.

I see the repro, but I guess it's still too large to make a good regression test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118877/new/

https://reviews.llvm.org/D118877



More information about the llvm-commits mailing list