[PATCH] D119332: [flang] Add Win32 to the list of supported triples

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 13:20:24 PST 2022


schweitz added a comment.

Out of curiosity, how much has this been tested? I wouldn't be surprised if there are some gotcha differences between the Windows and Linux ABIs...



================
Comment at: flang/lib/Optimizer/CodeGen/Target.cpp:241
 // Instantiate the overloaded target instance based on the triple value.
-// Currently, the implementation only instantiates `i386-unknown-linux-gnu`,
-// `x86_64-unknown-linux-gnu`, aarch64 and ppc64le like triples. Other targets
-// should be added to this file as needed.
+// TODO: Add other target to this file as needed.
 std::unique_ptr<fir::CodeGenSpecifics>
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119332/new/

https://reviews.llvm.org/D119332



More information about the llvm-commits mailing list