[PATCH] D115955: [SLP]Alternate vectorization for cmp instructions.

Wed Feb 9 12:29:11 PST 2022

lebedev.ri added a comment.

In D115955#3308744 <https://reviews.llvm.org/D115955#3308744>, @jyknight wrote:

> In D115955#3308207 <https://reviews.llvm.org/D115955#3308207>, @ABataev wrote:
>
>> It was reverted in 14, currently only in trunk.
>
> That doesn't appear to be accurate -- the revert, https://github.com/llvm/llvm-project/commit/0c3d22a5926dd7d6fd28682683abd9d476f8e78b didn't make it into 14.x branch cut, while the initial change, https://github.com/llvm/llvm-project/commit/83620bd2ad867f706c699d0f2b8be10e43d9f3d7 did. There is no cherry-pick revert subsequently on the branch, either.

I've filed https://github.com/llvm/llvm-project/issues/53678

SLPVectorizer patches seem extremely revert-prone, suggesting that the pass's code
is in need of a serous refactoring and in an increase of the amount of people who know that code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115955/new/

https://reviews.llvm.org/D115955