[PATCH] D119039: [RISCV] Recognize shuffles that rotate one vector or the concatenation of two vectors.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2514
+      // The rotations don't match, so we can't match this mask.
+      return -1;
+
----------------
khchen wrote:
> return 0?
Good catch! X86 used -1 and returned an int, but it would never return 0. Which I initially copied before changing to 0.

I'll add a negative test for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119039/new/

https://reviews.llvm.org/D119039