[PATCH] D119247: [NVPTX] Use align attribute for kernel pointer arg alignment

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: llvm/test/CodeGen/NVPTX/nvcl-param-align.ll:7
+define void @foo(i64 %img, i64 %sampler, <5 x float>* align 32 %v) {
+; The parameter alignment is determined by the align attribute.
 ; CHECK: .param .u32 .ptr .align 32 foo_param_2
----------------
nikic wrote:
> tra wrote:
> > What's expected to happen if the alignment is not specified explicitly?
> > 
> > It may be worth adding a test case for that.
> If no alignment is specified, then the default is 1. I've extended the test to check for this.
Always defaulting to unaligned access would likely be a performance regression.
LLVM IR spec generally defaults to `If the alignment is not specified, then the code generator makes a target-specific assumption.`
I think we do need to infer assumed alignment from the data layout, if we do know the type.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119247/new/

https://reviews.llvm.org/D119247