[PATCH] D118665: [Debuginfod] Flag-determine debuginfod lookups in llvm-symbolizer.

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath added inline comments.


================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:273-276
+  // A debuginfod lookup could also succeed if something were present in the
+  // cache directory, but it would be surprising to enable debuginfod on this
+  // basis alone. To use existing caches in an "offline" fashion, the debuginfod
+  // flag must be set.
----------------
phosek wrote:
> This is just a nit, but I find that having the comment here not followed by any code a bit confusing, especially since it's referring to logic inside `main`. I'd slightly prefer just inlining this function together with these comments into `main`.
This needed a bit more logic to merge with the other debuginfod changes, but I did rearrange it so the comment corresponds to an explicit return false. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118665/new/

https://reviews.llvm.org/D118665