[PATCH] D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: cross-project-tests/debuginfo-tests/llgdb-tests/asan-deque.cpp:7
 // UNSUPPORTED: apple-lldb-pre-1000
-// XFAIL: !system-darwin && gdb-clang-incompatibility
+// XFAIL: !system-darwin, (!system-darwin && gdb-clang-incompatibility)
+//        gdb doesn't pretty-print std::deque
----------------
Orlando wrote:
> StephenTozer wrote:
> > The second expression seems redundant, if `!system-darwin && gdb-clang-incompatibility` is true then `!system-darwin` is necessarily also true. Is this meant to be `!system-darwin, gdb-clang-incompatibility`?
> It is redundant yes. I figured it would be more obvious to anyone adjusting the test in the future that the second part is still necessary when the tests start passing on `!system-darwin`. wdyt?
Seems reasonable, but might be worth expanding the below comment to specify that it applies to the `!system-darwin` clause, since `system-darwin` being essentially a proxy for "run with LLDB instead of GDB" here might not be obvious to someone unfamiliar with these tests. Something like "failing on non-darwin (gdb) builds because gdb doesn't pretty-print std::deque" or something along those lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118760/new/

https://reviews.llvm.org/D118760