[PATCH] D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 04:13:43 PST 2022


StephenTozer added a comment.

LGTM apart from the comment below.



================
Comment at: cross-project-tests/debuginfo-tests/llgdb-tests/asan-deque.cpp:7
 // UNSUPPORTED: apple-lldb-pre-1000
-// XFAIL: !system-darwin && gdb-clang-incompatibility
+// XFAIL: !system-darwin, (!system-darwin && gdb-clang-incompatibility)
+//        gdb doesn't pretty-print std::deque
----------------
The second expression seems redundant, if `!system-darwin && gdb-clang-incompatibility` is true then `!system-darwin` is necessarily also true. Is this meant to be `!system-darwin, gdb-clang-incompatibility`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118760/new/

https://reviews.llvm.org/D118760



More information about the llvm-commits mailing list