[PATCH] D118979: [AArch64] Set maximum VF with shouldMaximizeVectorBandwidth
    JinGu Kang via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Feb  9 04:13:25 PST 2022
    
    
  
jaykang10 updated this revision to Diff 407116.
jaykang10 added a comment.
@paulwalker-arm As you can see, there are regression tests which are failed to generate scalable vector type with the `shouldMaximizeVectorBandwidth`.
Previously, I saw these regression tests were failed because of the cost so I returned false with SVE in `shouldMaximizeVectorBandwidth`...
I am not sure it is acceptable that LV selects VF 16 instead of scalable vector type on SVE...
If it is not acceptable, we could need to tune the cost on SVE and I would like to suggest to use `shouldMaximizeVectorBandwidth` for only neon until finishing the cost tune...
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118979/new/
https://reviews.llvm.org/D118979
Files:
  llvm/include/llvm/Analysis/TargetTransformInfo.h
  llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
  llvm/lib/Analysis/TargetTransformInfo.cpp
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h
  llvm/lib/Target/Hexagon/HexagonTargetTransformInfo.h
  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
  llvm/test/Transforms/LoopVectorize/AArch64/extend-vectorization-factor-for-unprofitable-memops.ll
  llvm/test/Transforms/LoopVectorize/AArch64/loop-vectorization-factors.ll
  llvm/test/Transforms/LoopVectorize/AArch64/reduction-small-size.ll
  llvm/test/Transforms/LoopVectorize/AArch64/scalable-vectorization-cost-tuning.ll
  llvm/test/Transforms/LoopVectorize/AArch64/scalable-vectorization.ll
  llvm/test/Transforms/LoopVectorize/AArch64/sve-illegal-type.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118979.407116.patch
Type: text/x-patch
Size: 13153 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220209/a74d788b/attachment.bin>
    
    
More information about the llvm-commits
mailing list