[llvm] db28a45 - [AMDGPU] Remove irrelevant comments on V_BFE_I32 instructions

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 04:07:53 PST 2022


Author: Jay Foad
Date: 2022-02-09T12:06:29Z
New Revision: db28a45617be87952c6ad7b2092da270d72048e7

URL: https://github.com/llvm/llvm-project/commit/db28a45617be87952c6ad7b2092da270d72048e7
DIFF: https://github.com/llvm/llvm-project/commit/db28a45617be87952c6ad7b2092da270d72048e7.diff

LOG: [AMDGPU] Remove irrelevant comments on V_BFE_I32 instructions

These comments explain the encoding of the immediate operand of S_BFE_*
which is not relevant for V_BFE_I32.

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/SIInstructions.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/SIInstructions.td b/llvm/lib/Target/AMDGPU/SIInstructions.td
index 7fe3524906611..095ca4c303bad 100644
--- a/llvm/lib/Target/AMDGPU/SIInstructions.td
+++ b/llvm/lib/Target/AMDGPU/SIInstructions.td
@@ -1990,12 +1990,12 @@ def : GCNPat<(i32 (DivergentSextInreg<i1> i32:$src)),
 
 def : GCNPat <
   (i16 (DivergentSextInreg<i1> i16:$src)),
-  (V_BFE_I32_e64 $src, (i32 0), (i32 1)) // 0 | 1 << 16
+  (V_BFE_I32_e64 $src, (i32 0), (i32 1))
 >;
 
 def : GCNPat <
   (i16 (DivergentSextInreg<i8> i16:$src)),
-  (V_BFE_I32_e64 $src, (i32 0), (i32 8)) // 0 | 8 << 16
+  (V_BFE_I32_e64 $src, (i32 0), (i32 8))
 >;
 
 def : GCNPat <
@@ -2008,14 +2008,14 @@ def : GCNPat <
 def : GCNPat <
   (i64 (DivergentSextInreg<i8> i64:$src)),
   (REG_SEQUENCE VReg_64,
-    (V_BFE_I32_e64 (i32 (EXTRACT_SUBREG i64:$src, sub0)), (i32 0), (i32 8)/* 0 | 8 << 16 */), sub0,
+    (V_BFE_I32_e64 (i32 (EXTRACT_SUBREG i64:$src, sub0)), (i32 0), (i32 8)), sub0,
     (V_ASHRREV_I32_e32 (i32 31), (V_BFE_I32_e64 (i32 (EXTRACT_SUBREG i64:$src, sub0)), (i32 0), (i32 8))), sub1)
 >;
 
 def : GCNPat <
   (i64 (DivergentSextInreg<i16> i64:$src)),
   (REG_SEQUENCE VReg_64,
-    (V_BFE_I32_e64 (i32 (EXTRACT_SUBREG i64:$src, sub0)), (i32 0), (i32 16)/* 0 | 16 << 16 */), sub0,
+    (V_BFE_I32_e64 (i32 (EXTRACT_SUBREG i64:$src, sub0)), (i32 0), (i32 16)), sub0,
     (V_ASHRREV_I32_e32 (i32 31), (V_BFE_I32_e64 (i32 (EXTRACT_SUBREG i64:$src, sub0)), (i32 0), (i32 16))), sub1)
 >;
 


        


More information about the llvm-commits mailing list