[PATCH] D119318: ReleaseNotes: add lld/ELF notes

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Some wording comments. I haven't been following LLD closely enough to be able to identify whether anything should/should not be documented in the release notes that isn't/is here though.



================
Comment at: lld/docs/ReleaseNotes.rst:39
+  (`D104431 <https://reviews.llvm.org/D104431>`_)
+* Archives without index (symbol table) are now supported and work with
+  ``--warn-backrefs``. One may build such an archive with ``llvm-ar rcS
----------------



================
Comment at: lld/docs/ReleaseNotes.rst:44
+  The archive index may be `entirely ignored
+  <https://reviews.llvm.org/D119074>` in the next release.
 * No longer deduplicate local symbol names at the default optimization level of ``-O1``.
----------------
MaskRay wrote:
> Note this archive thing to improve performance and simplify symbol resolution.
> 
> (Note: mold already did this)
Given that this is only a "may", I might recommend changing "in the next release" to "in a future release".


================
Comment at: lld/docs/ReleaseNotes.rst:61
+  (`D113771 <https://reviews.llvm.org/D113771>`_)
+* ``--compress-debug-sections=zlib`` is now parallel. ``{clang,gcc} -gz`` link
+  actions are significantly faster.
----------------
I would suggest "is now run in parallel" instead of "is now parallel".


================
Comment at: lld/docs/ReleaseNotes.rst:67-68
+  (`D112518 <https://reviews.llvm.org/D117853>`_)
+* The write of ``SHF_MERGE|SHF_STRINGS`` sections (e.g. ``.debug_str``) are now
+  parallel.
 
----------------



================
Comment at: lld/docs/ReleaseNotes.rst:82
+* The x86-32 and x86-64 ports now support mixed TLSDESC and TLS GD, i.e. mixing
+  ``-mtls-dialect=gnu2`` compiled .o with .o without the option are now
+  supported.
----------------
MaskRay wrote:
> Perhaps: .o files compiled with and without ``-mtls-dialect=gnu2`` can now be linked together.
I'd use "object" or "objects" instead of ".o", as I feel the ".o" shortening doesn't feel right given the rest of the sentence is full prose. Concrete suggestion:

"i.e. mixing objects compiled with and without `-mtls-dialect=gnu2` is now supported."


================
Comment at: lld/docs/ReleaseNotes.rst:102-103
+  (`D110209 <https://reviews.llvm.org/D110209>`_)
+* Use of ``--[no-]define-common``, ``-d``, ``-dc``, and ``-dp`` will now get a
+  warning. They will be removed or ignored in 15.0.0.
+  (`llvm-project#53660 <https://github.com/llvm/llvm-project/issues/53660>`_)
----------------
MaskRay wrote:
> The warning change has not been made yet.
Again, not locking into a specific release in case things change/get delayed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119318/new/

https://reviews.llvm.org/D119318