[PATCH] D118026: [RISCV] Improve the condition of hasRVVFrameObject.

Jianjian Guan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 01:16:30 PST 2022


jacquesguan added a comment.

In D118026#3266530 <https://reviews.llvm.org/D118026#3266530>, @craig.topper wrote:

> Is it possible write a test for this?

I add a case to show the difference when the function will not use any rvv.



================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:952
   //
   // The function is changed to use hasVInstructions() as the return value. It
   // is not precise, but it can make the register allocation correct.
----------------
craig.topper wrote:
> Does this comment need to be updated?
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118026/new/

https://reviews.llvm.org/D118026



More information about the llvm-commits mailing list