[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

[Jakub Chlanda via Phabricator via llvm-commits]

jchlanda added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXIntrinsics.td:937
+class FMA_TUPLE<string V, Intrinsic I, NVPTXRegClass RC,
+                list<Predicate> Preds = [hasPTX70, hasSM80]> {
+  string Variant = V;
----------------
tra wrote:
>  I think the default should be the most useful/common and the least surprising value.
> I'd argue that in this case it would be `[]`.  This would give reader a reasonable idea about what's going on even without looking at FMA_TUPLE implementation.
Agreed, I wrote that class before folding in f32 and f64, `hasPTX70, hasSM80` made more sense then. Changed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118977/new/

https://reviews.llvm.org/D118977