[PATCH] D119219: [llvm-rc]: Find <target>-clang over just clang

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 9 00:21:22 PST 2022


thieta added a comment.

In D119219#3307031 <https://reviews.llvm.org/D119219#3307031>, @MaskRay wrote:

>> This is so that we can have a .cfg file for <target> and configure sysroot and other important flags.
>
> I know nearly nothing about llvm-rc... but I wonder whether there is a better way.

Maybe the config file searching could be expanded to find config files based on target from other things than the target prefix? But that changes more than just around `llvm-rc`. I suggested that we would look for the sysroot based on the target in this discussion: https://discourse.llvm.org/t/teach-clang-to-find-a-sysroot-based-on-target-in-resource-dir/6100 and the answer to that was the config files, which makes sense since they are a bit more flexible and you might want to set other flags than just `--sysroot`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119219/new/

https://reviews.llvm.org/D119219



More information about the llvm-commits mailing list