[PATCH] D118771: [sanitizer_common] Fix DenseMapCustomTest.DefaultMinReservedSizeTest on SPARC
Rainer Orth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 9 00:10:34 PST 2022
ro added inline comments.
================
Comment at: compiler-rt/lib/sanitizer_common/tests/sanitizer_dense_map_test.cpp:413
+ // DenseMap (see DefaultMinReservedSizeTest).
+ for (auto Size : {1, 2, 48, 66, 341, ExpectedInitialBucketCount + 1}) {
DenseMap<int, CountCopyAndMove> Map(Size);
----------------
vitalybuka wrote:
> Just two instances, so I'd rather hardcoded it here.
> Either way is fine to me.
I've decided to keep the code as is: it avoids duplication and possible inconsistencies as well as an unexplained magical constant (8).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118771/new/
https://reviews.llvm.org/D118771
More information about the llvm-commits
mailing list