[PATCH] D119087: [AMDGPU] [NFC] refactor the AMDGPU attributor

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:400
 
-    // If we found that we need amdgpu-queue-ptr, nothing else to do.
+    NeedsQueuePtr |= checkForQueuePtr(A);
     if (NeedsQueuePtr) {
----------------
sameerds wrote:
> cfang wrote:
> > I don't think we need to checkForQueuePtr when NeedsQueuePtr is 
> > true. 
> Indeed. I am relying on the short-circuiting nature of the logical-or to achieve that.
Turns out that this is actually the bitwise operator and it is not short-circuiting. Fixed in D119308. Thanks for catching this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119087/new/

https://reviews.llvm.org/D119087