[PATCH] D119261: [DependenceAnalysis][PR52170] Conservative crash on overflowed loop backedge

Tue Feb 8 14:16:23 PST 2022

Meinersbur added a comment.

Please mention the bug number in the summary as well.

Do you know what was the purpose of the check was? Usually those are not added without reason. In particular, it seems that it has been added in rGc0661aeaf8daf371023cf5669be4bd9b428882d0 <https://reviews.llvm.org/rGc0661aeaf8daf371023cf5669be4bd9b428882d0>. What if the code is called when not reclassfying a SIV reclassification?

> SCEVs already do the overflow checks that the code was targeting.

Can you clarify? There is a reason why SCEVs have nsw/nuw flags.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119261/new/

https://reviews.llvm.org/D119261