[PATCH] D119127: Preserve inbounds information of GEP during Argument Promotion Pass across callee and its callers.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D119127#3304281 <https://reviews.llvm.org/D119127#3304281>, @pravinjagtap wrote:

> In D119127#3300894 <https://reviews.llvm.org/D119127#3300894>, @nikic wrote:
>
>> It looks like you need to update a number of existing tests.
>>
>> You should also test the case where the GEP inbounds is conditional -- I think it might still be okay based on a dereferenceabiliy argument, but it's not entirely obvious to me.
>
> Thank you for your inputs. I am not sure whether I fully understood what do you mean by `GEP inbounds is conditional`.  I am assuming that test should include: GEP with inbound and without inbound in callee so that other conditional branch will be exercised.

Sorry for the confusion: What I meant is a case where the GEP + load is not guaranteed to execute on entry to the function, but is behind a conditional branch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119127/new/

https://reviews.llvm.org/D119127