[PATCH] D119247: [NVPTX] Use align attribute for kernel pointer arg alignment

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

> make use of alignment annotations added by the frontend.

Does it mean that we now require explicit alignment annotation to generate reasonable code? What happens if alignment is not specified explicitly? Do we fall back to unaligned/naturally aligned/something else?



================
Comment at: llvm/test/CodeGen/NVPTX/nvcl-param-align.ll:7
+define void @foo(i64 %img, i64 %sampler, <5 x float>* align 32 %v) {
+; The parameter alignment is determined by the align attribute.
 ; CHECK: .param .u32 .ptr .align 32 foo_param_2
----------------
What's expected to happen if the alignment is not specified explicitly?

It may be worth adding a test case for that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119247/new/

https://reviews.llvm.org/D119247