[PATCH] D118489: [AArch64] Allow strict opcodes in faddp patterns

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14372
+      // instruction, so instead morph the strict_fadd.
+      DAG.MorphNodeTo(N0.getNode(), N0->getOpcode(),
+                      DAG.getVTList(VT, MVT::Other),
----------------
I don't think you can use MorphNodeTo here. It has a comment about it in the description of the function.

Can it just use one of the ReplaceAllUsesWith/ReplaceAllUsesOfValueWith/CombineTo/etc methods? As far as I understand it needs to replace the old Chain (from N0) with the new one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118489/new/

https://reviews.llvm.org/D118489