[PATCH] D95617: [DWARF] Inlined variables with no location should not have a DW_TAG_variable

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 8 10:24:47 PST 2022


dblaikie added a comment.

In D95617#3300552 <https://reviews.llvm.org/D95617#3300552>, @ro wrote:

> `no-empty-child-vars.ll` FAILs on SPARC: the first
>
>   ; CHECK:     DW_TAG_subprogram
>   ; CHECK:       DW_AT_abstract_origin (0x{{[0-9a-f]*}} "foo")
>
> is missing completely and both `qux` and `croix` lack `DW_TAG_inlined_subroutine`.
>
> Any suggestion what to do about this?
>
> Thanks.

Did the add instructions get somehow lost in Sparc? (like they got merged into the ret instruction somehow, or something in the Sparc backend transformed the add instructions and lost the debug locations along the way? Perhaps that could/should be fixed - but also, I think using `call` instructions rather than `add` instructions is more robust for this sort of testing (call to an opaque/declared-but-not-defined function is unlikely to get transformed in interesting ways or lose its debug location), so the test case could be changed to do that)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95617/new/

https://reviews.llvm.org/D95617



More information about the llvm-commits mailing list