[PATCH] D118981: [VP] Condition in vp.select|merge not a VP mask

Tue Feb 8 09:46:33 PST 2022

frasercrmck added a comment.

Makes sense to me: it's not a mask. I was looking around to see what knock-on effects this has, and good news is that I think this fixes a bug we're not testing where an all-zeros "mask" will DAGCombine to `undef` (`visitVPOp`). Could you maybe pre-commit a test for that and show this patch fixing it?

On that note: I don't know if this is truly a child of D105283 <https://reviews.llvm.org/D105283>. Can't we merge it right away?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118981/new/

https://reviews.llvm.org/D118981