[PATCH] D119252: [AArch64][SVE] Fix selection failure during lowering of shuffle_vector

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9732
+    // Can't handle cases where vector size is greater than 128-bit
+    if (Extract.getOperand(0).getValueSizeInBits() > 128)
+      return false;
----------------
You're introducing a new TypeSize -> uint64_t implicit typecast here. Can you use this instead?

  if (Extract.getOperand(0).getValueSizeInBits().getFixedSizeInBits() > 128)


================
Comment at: llvm/test/CodeGen/AArch64/sve-shuffle-crash.ll:1
+; RUN: llc < %s
+
----------------
bsmith wrote:
> david-arm wrote:
> > Hi @bsmith, there don't seem to be any CHECK lines here. Could you add some please using the llvm/utils/update_llc_test_checks.py script?
> I intentionally didn't put any in here, the resulting codegen is large and uninteresting in this case, the failure mode is a crash which will be caught regardless.
> 
> I can put some in though if you think it would be valuable?
Hmm, I do realise the CHECK lines probably look awful, but maybe it's still worth it? I imagine if the code quality is really that terrible, we'll probably want to improve that at some point and at least we'll be defending it. If we improve codegen in future we'll see reduced CHECK lines here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119252/new/

https://reviews.llvm.org/D119252