[PATCH] D119253: [flang][codegen] Keep primitive type for extractvalue and insertvalue

[Valentin Clement via Phabricator via llvm-commits]

clementval created this revision.
clementval added reviewers: jeanPerier, kiranchandramohan, PeteSteinfeld, schweitz, svedanayagam.
Herald added a subscriber: mehdi_amini.
Herald added a project: Flang.
clementval requested review of this revision.
Herald added subscribers: llvm-commits, jdoerfert.
Herald added a project: LLVM.

llvm.insertvalue and llvm.extractvalue need LLVM primitive type
for the indexing operands. While upstreaming the TargetRewrite pass the change
was made from i32 to index without knowing this restriction. This patch reverts
back the types used for indexing in the two ops created in this pass.

the error you will receive when lowering to LLVM IR with the current code
is the following:

  'llvm.insertvalue' op operand #1 must be primitive LLVM type, but got 'index'


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119253

Files:
  flang/lib/Optimizer/CodeGen/TargetRewrite.cpp
  flang/test/Fir/target-rewrite-complex.fir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119253.406844.patch
Type: text/x-patch
Size: 12006 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220208/33b26496/attachment.bin>