[PATCH] D119141: The device expression must evaluate to a non-negative integer value.

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

The precheck is still failing. Please have a look why the patch application fails.



================
Comment at: flang/lib/Semantics/check-directive-structure.h:554
   if (const auto v{GetIntValue(i)}) {
-    if (*v <= 0) {
+    if (*v < 0) {
       context_.Say(GetContext().clauseSource,
----------------
Since you want to accept 0 please add a valid test with 0 so that we will catch any change in the future. 


================
Comment at: llvm/lib/Support/FormatVariadic.cpp:21
     return AlignStyle::Right;
+  default:
+    return None;
----------------
Unrelated change. Please remove. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119141/new/

https://reviews.llvm.org/D119141