[PATCH] D119237: [AMDGPURewriteOutArguments] Don't use pointer element type

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 8 05:35:39 PST 2022


nikic created this revision.
nikic added a reviewer: arsenm.
Herald added subscribers: foad, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
nikic requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Instead of using the pointer element type, look at how the pointer is actually being used in store instructions, while looking through bitcasts. This makes the transform compatible with opaque pointers and a bit more general.

It's worth noting that I have dropped the 3-vector to 4-vector shufflevector special case, because this is now handled in a different way: If the value is actually used as a 4-vector, then we're directly going to use that type, instead of shuffling to a 3-vector in between.


https://reviews.llvm.org/D119237

Files:
  llvm/lib/Target/AMDGPU/AMDGPURewriteOutArguments.cpp
  llvm/test/CodeGen/AMDGPU/rewrite-out-arguments-address-space.ll
  llvm/test/CodeGen/AMDGPU/rewrite-out-arguments.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119237.406784.patch
Type: text/x-patch
Size: 34547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220208/d52b50dc/attachment.bin>


More information about the llvm-commits mailing list