[PATCH] D119219: [llvm-rc]: Find <target>-clang over just clang

[Tobias Hieta via Phabricator via llvm-commits]

thieta added a comment.

In D119219#3303792 <https://reviews.llvm.org/D119219#3303792>, @mstorsjo wrote:

> For these cases, I guess we'd end up executing `<triple>-clang -target <triple>`, which is a bit redundant, but it's probably not worth complicating the code to avoid that.

Yeah I was looking into this - but it seemed a bit complicated to remove the `-target` in the invocation and made the code more complicated just for a cosmetic issue that is only visible if you pass verbose to llvm-windres and look at the output. It didn't think it was worth it.

> Ideally we'd have a test for this, but I think such a test for this can be pretty hard to fit into the test framework, so it can probably go in without.

Same I also looked into this and couldn't figure out a decent way to do this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119219/new/

https://reviews.llvm.org/D119219