[PATCH] D119108: [ELF] Remove GNU ld incompatible --[no-]define-common and obscure -dc/-dp

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

While in this case I think you are right, and no-one using LLD will be depending on this. I'm a bit uncomfortable with taking options out without a bit more warning and chance for feedback. I think it could be worth using this to set out LLD's deprecation/removal process. For example for options that maintainers want to remove we've got several options, or even a combination depending on circumstances:

- Option will be deprecated (with a silenceable warning) for a release, then removed in the subsequent release.
- Option will be removed if there is no use of it in an open source project.
- Option will be removed if a post on the community discourse/mailing lists, github issue has no one feedback with a good reason to keep it within a certain time frame.
- Option will be set to silent ignore if a valid, if sub-optimal output can be produced without applying the option.

I'd strongly recommend that we at least make a github issue (more search engine friendly than a review) and a post on discourse first. Ideally agree some kind of process so that people using LLD can know what to expect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119108/new/

https://reviews.llvm.org/D119108