[PATCH] D118975: [AMDGPU] Allow hoisting of some VALU compare instructions

[Carl Ritson via Phabricator via llvm-commits]

critson marked an inline comment as done.
critson added a comment.

In D118975#3302072 <https://reviews.llvm.org/D118975#3302072>, @nhaehnle wrote:

> I suspect that V_CNDMASK uses are fairly common, and those implicitly mask with EXEC as well.
>
> This also doesn't address more complex cases like
>
>   %0 = V_CMP ...
>   %1 = V_CMP ...
>   %2 = S_OR %0, %1
>   V_CNDMASK lhs, rhs, %2
>
> though perhaps the change is good as-is for now.

Thanks for pointing this out.

I think it makes sense to look at additional patterns in a follow up patch.
IMO it's safer to expand the set of allowable hoists iteratively (testing as we go).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118975/new/

https://reviews.llvm.org/D118975