[PATCH] D119177: [demangler] Fix buffer growth

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 18:24:03 PST 2022


ChuanqiXu added inline comments.


================
Comment at: libcxxabi/src/demangle/Utility.h:42
+      if (Need > BufferCapacity) {
+        if (!BufferCapacity && Need < 100)
+          // Avoid many reallocations during startup
----------------
What's the meaning of the magic number 100? Generally we should make it configurable or at least we should give a name to it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119177/new/

https://reviews.llvm.org/D119177



More information about the llvm-commits mailing list