[PATCH] D116832: [UpdateLLCTestChecks] Allow replacing register names with variables
Phoebe Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 7 18:11:46 PST 2022
pengfei added a comment.
I think my concerns still exist, even though you provide one more option. The author selects between cannot foresee what in their tests will be affected by future commit. And the `--scrub-reg deps` loses too much information.
Besides, comparing the introdued complexity in `asm.py` and the (probably) limited benefit, it's not a good deal to me.
So back to @lebedev.ri 's question, if this is mainly for downstream use, it's better to keep it downstream. Otherwise, please give a scope which in tree tests you want to apply it to, so that we can judge the value based on that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116832/new/
https://reviews.llvm.org/D116832
More information about the llvm-commits
mailing list